Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stdlib::sha256 #1289

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Add stdlib::sha256 #1289

merged 1 commit into from
Jan 16, 2023

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Jan 9, 2023

This exposes the sha256 function for computation against random data.

@jcpunk jcpunk requested a review from a team as a code owner January 9, 2023 20:46
@puppet-community-rangefinder
Copy link

stdlib::sha256 is a function

that may have no external impact to Forge modules.

This module is declared in 318 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit 41c6aef into puppetlabs:main Jan 16, 2023
@david22swan
Copy link
Member

@jcpunk Thank's for putting in the work

@jcpunk jcpunk deleted the sha256 branch January 17, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants